Fix --with-quic builds
#57225
Closed
Fix --with-quic builds
#57225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
needs-ci
lpinca
approved these changes
Feb 27, 2025
Add source file introduced in ngtcp2 1.11.0 to `ngtcp2.gyp`. Refs: nodejs#57179
`parallel/test-config-json-schema` compares to a generated fixture that assumes that Node.js was built with default configuration settings. Skip the test if non-default quic is enabled (`configure --with-quic`). Refs: nodejs#57016 Refs: nodejs#57142
richardlau
force-pushed
the
sharedwithquic
branch
from
03f3ca4 to
62931d6
Compare
|
(updated to fix a typo in the first commit message) |
lpinca
approved these changes
Feb 27, 2025
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
Feb 27, 2025
cjihrig
approved these changes
Feb 27, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57225 +/- ##
==========================================
+ Coverage 90.25% 90.27% +0.02%
==========================================
Files 630 630
Lines 184681 184681
Branches 36147 36141 -6
==========================================
+ Hits 166682 166719 +37
+ Misses 11024 11018 -6
+ Partials 6975 6944 -31 |
anonrig
approved these changes
Feb 27, 2025
richardlau
added
author ready
richardlau
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in ed22a68...60dff42 |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Mar 1, 2025
`parallel/test-config-json-schema` compares to a generated fixture that assumes that Node.js was built with default configuration settings. Skip the test if non-default quic is enabled (`configure --with-quic`). Refs: #57016 Refs: #57142 PR-URL: #57225 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Mar 11, 2025
`parallel/test-config-json-schema` compares to a generated fixture that assumes that Node.js was built with default configuration settings. Skip the test if non-default quic is enabled (`configure --with-quic`). Refs: #57016 Refs: #57142 PR-URL: #57225 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos
pushed a commit
that referenced
this pull request
Mar 11, 2025
`parallel/test-config-json-schema` compares to a generated fixture that assumes that Node.js was built with default configuration settings. Skip the test if non-default quic is enabled (`configure --with-quic`). Refs: #57016 Refs: #57142 PR-URL: #57225 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deps: update gyp file for ngtcp2 1.11.0
Add source file introduced in ngtcp2 1.11.0 to
ngtcp2.gyp.test: skip test-config-json-schema with quic
parallel/test-config-json-schemacompares to a generated fixture thatassumes that Node.js was built with default configuration settings.
Skip the test if non-default quic is enabled (
configure --with-quic).#57142 made quic support opt-in -- this PR fixes the
configure --with-quicbuild.I've created a new CI job in Jenkins, node-test-commit-linux-quic, to test this configuration.
main(c7cf677): https://ci.nodejs.org/job/node-test-commit-linux-quic/1/ (fails)