-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: use Maybe<void> in ProcessEmitWarningSync #57250
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.cxx-250302.Sun.db33
Mar 6, 2025
Merged
src: use Maybe<void> in ProcessEmitWarningSync #57250
nodejs-github-bot
merged 1 commit into
nodejs:main
from
daeyeon:main.cxx-250302.Sun.db33
Mar 6, 2025
+6
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57250 +/- ##
==========================================
- Coverage 90.24% 90.24% -0.01%
==========================================
Files 630 630
Lines 184920 184920
Branches 36198 36182 -16
==========================================
- Hits 166884 166883 -1
- Misses 11059 11061 +2
+ Partials 6977 6976 -1
🚀 New features to boost your workflow:
|
targos
approved these changes
Mar 1, 2025
jasnell
approved these changes
Mar 1, 2025
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
30254a1
to
b15000b
Compare
Jenkins failed because of merge conflicts from the 7c910d0. Rebased. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Mar 6, 2025
Landed in 117c1ca |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #57250 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #57250 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
c++
Issues and PRs that require attention from people who are familiar with C++.
needs-ci
PRs that need a full CI run.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch uses
Maybe<void>
in the function where only the success result seems needed.