Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use Maybe<void> in ProcessEmitWarningSync #57250

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

daeyeon
Copy link
Member

@daeyeon daeyeon commented Mar 1, 2025

This patch uses Maybe<void> in the function where only the success result seems needed.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 1, 2025
Copy link

codecov bot commented Mar 1, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.24%. Comparing base (5ac9551) to head (b15000b).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
src/node_process_events.cc 50.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57250      +/-   ##
==========================================
- Coverage   90.24%   90.24%   -0.01%     
==========================================
  Files         630      630              
  Lines      184920   184920              
  Branches    36198    36182      -16     
==========================================
- Hits       166884   166883       -1     
- Misses      11059    11061       +2     
+ Partials     6977     6976       -1     
Files with missing lines Coverage Δ
src/node_process.h 25.00% <ø> (ø)
src/node_process_events.cc 59.09% <50.00%> (ø)

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daeyeon daeyeon added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 2, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 2, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
@daeyeon daeyeon force-pushed the main.cxx-250302.Sun.db33 branch from 30254a1 to b15000b Compare March 4, 2025 01:17
@daeyeon
Copy link
Member Author

daeyeon commented Mar 4, 2025

09:50:29 ../src/node_process_events.cc: In function 'v8::Maybe<void> node::ProcessEmitWarningSync(Environment*, std::string_view)':
09:50:29 ../src/node_process_events.cc:32:25: error: could not convert 'v8::Nothing<bool>()' from 'Maybe<bool>' to 'Maybe<void>'
09:50:29    32 |     return Nothing<bool>();
09:50:29       |            ~~~~~~~~~~~~~^~
09:50:29       |                         |
09:50:29       |                         Maybe<bool>

Jenkins failed because of merge conflicts from the 7c910d0. Rebased.

@daeyeon daeyeon added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2025
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@daeyeon
Copy link
Member Author

daeyeon commented Mar 6, 2025

@targos @jasnell I've updated the code to fix the merge conflict. PTAL.

@daeyeon daeyeon added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 6, 2025
@nodejs-github-bot nodejs-github-bot merged commit 117c1ca into nodejs:main Mar 6, 2025
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 117c1ca

aduh95 pushed a commit that referenced this pull request Mar 9, 2025
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #57250
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this pull request Mar 9, 2025
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
PR-URL: #57250
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants