src: refactor SubtleCrypto algorithm and length validations #57273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
lib / src
|
cc @nodejs/web-standards |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57273 +/- ##
==========================================
+ Coverage 90.24% 90.26% +0.02%
==========================================
Files 630 630
Lines 184908 184921 +13
Branches 36181 36196 +15
==========================================
+ Hits 166874 166923 +49
+ Misses 11061 11026 -35
+ Partials 6973 6972 -1
|
panva
force-pushed
the
webcrypto-refactored-validations
branch
from
18888dc to
9b119b2
Compare
jasnell
approved these changes
Mar 2, 2025
panva
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
webcrypto-refactored-validations
branch
from
9b119b2 to
37988fa
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
panva
force-pushed
the
webcrypto-refactored-validations
branch
from
37988fa to
a1aa1be
Compare
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jazelly
approved these changes
Mar 3, 2025
panva
added
commit-queue-squash
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
approved these changes
Mar 3, 2025
MattiasBuelens
approved these changes
Mar 4, 2025
| } | ||
|
|
||
| function eddsaSignVerify(key, data, algorithm, signature) { | ||
| validateEdDSASignVerifyAlgorithm(algorithm); |
There was a problem hiding this comment.
This changes the order of the checks. Previously, we first checked (key.type !== type) and then checked (name === 'Ed448' && context?.byteLength). Now, it's the other way around.
It seems like we're not really following the strict order from the specification for other algorithms either. So I guess this is fine?
There was a problem hiding this comment.
Yeah, the (name === 'Ed448' && context?.byteLength) check is our own because we don't support non-empty contexts. From the (early draft warning) supports method proposal this falls under
If the specified operation or algorithm (or one of its parameter values) is expected to fail (for any key and/or data) for an implementation-specific reason (e.g. known nonconformance to the specification), return false.
There was a problem hiding this comment.
I have a draft PR for the supports method in #57270 that I will further refactor this PR's validations structures in when it lands.
panva
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 6fdd4e6 |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57273 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57273 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jason Zhang <xzha4350@gmail.com> Reviewed-By: Mattias Buelens <mattias@buelens.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the algorithm operation validations of the normalized algorithm and length (where applicable) that can be performed without accessing parameters such as key, data, ciphertext, etc.
This will allow #57270 to invoke these sync validations as part of the
SubtleCrypto.supports()steps without repeating them in its own implementation.This code is well tested throught WebCryptoAPI WPTs and I've also covered some previously missed lines in our own test suite.