src: fix typo in comment #57291
Closed
src: fix typo in comment #57291
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
legendecas
approved these changes
Mar 3, 2025
richardlau
approved these changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57291 +/- ##
==========================================
+ Coverage 90.24% 90.26% +0.01%
==========================================
Files 630 630
Lines 184920 184920
Branches 36186 36187 +1
==========================================
+ Hits 166874 166910 +36
+ Misses 11059 11050 -9
+ Partials 6987 6960 -27
|
jakecastelli
approved these changes
Mar 4, 2025
jakecastelli
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57291 ✔ Done loading data for nodejs/node/pull/57291 ----------------------------------- PR info ------------------------------------ Title src: fix typo in comment (#57291) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:fix-typo -> nodejs:main Labels util, c++, fast-track, author ready Commits 1 - src: fix typo in comment Committers 1 - Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57291 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57291 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 03 Mar 2025 13:51:42 GMT ✔ Approvals: 3 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/57291#pullrequestreview-2654242823 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/57291#pullrequestreview-2654385334 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/57291#pullrequestreview-2657770409 ℹ This PR is being fast-tracked ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13655797837 |
|
I knew it, cq probably should check for |
jakecastelli
removed
the
commit-queue-failed
jakecastelli
pushed a commit
that referenced
this pull request
Mar 4, 2025
PR-URL: #57291 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
|
Landed in 559d481 |
aduh95
added a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57291 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
aduh95
added a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57291 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.