Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: move RaisinTen back to collaborators, triagers and SEA champion #57292

Merged
merged 1 commit into from
Mar 7, 2025
Merged

meta: move RaisinTen back to collaborators, triagers and SEA champion #57292

merged 1 commit into from
Mar 7, 2025

Conversation

RaisinTen
Copy link
Member

@RaisinTen
meta: move RaisinTen back to collaborators, triagers and SEA champion
4e4dd5c 
Refs: nodejs/TSC#1690
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 3, 2025
juanarbol
juanarbol approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@juanarbol juanarbol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No a TSC member, but from my side; I'm glad to have you back <3

mcollina
mcollina approved these changes Mar 3, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, welcome back!

@RaisinTen
Copy link
Member Author

Can someone please add me to the teams, so that I can land this PR? Thanks.

mhdawson
mhdawson approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 9325697 into nodejs:main Mar 7, 2025
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 9325697

@RaisinTen RaisinTen deleted the meta-move-RaisinTen-back-to-collaborators-triagers-champ branch March 8, 2025 05:24
aduh95 pushed a commit that referenced this pull request Mar 9, 2025
@RaisinTen @aduh95
meta: move RaisinTen back to collaborators, triagers and SEA champion
bc3202a 
Refs: nodejs/TSC#1690
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57292
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Mar 9, 2025
@RaisinTen @aduh95
meta: move RaisinTen back to collaborators, triagers and SEA champion
ee5ce5c 
Refs: nodejs/TSC#1690
Signed-off-by: Darshan Sen <raisinten@gmail.com>
PR-URL: #57292
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@mhdawson
Copy link
Member

Looks like @RaisinTen was added to the teams requested.

@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@MoLow MoLow MoLow approved these changes

@mhdawson mhdawson mhdawson approved these changes

@juanarbol juanarbol juanarbol approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.