-
Notifications
You must be signed in to change notification settings - Fork 30.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip uv-thread-name on IBM i #57299
Merged
nodejs-github-bot
merged 1 commit into
nodejs:main
from
abmusse:ibmi-skip-uv-thread-name
Mar 5, 2025
Merged
test: skip uv-thread-name on IBM i #57299
nodejs-github-bot
merged 1 commit into
nodejs:main
from
abmusse:ibmi-skip-uv-thread-name
Mar 5, 2025
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
approved these changes
Mar 3, 2025
jasnell
approved these changes
Mar 3, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57299 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 630 630
Lines 184920 184920
Branches 36186 36185 -1
=======================================
+ Hits 166874 166879 +5
+ Misses 11059 11057 -2
+ Partials 6987 6984 -3 |
lpinca
approved these changes
Mar 4, 2025
Landed in 8342183 |
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57299 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Mar 9, 2025
PR-URL: #57299 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
addons
Issues and PRs related to native addons.
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
needs-ci
PRs that need a full CI run.
test
Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to AIX, IBM i does not support get/set thread name from libuv.
See: libuv/libuv#4599 (comment)
CC
@nodejs/platform-ibmi