Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test runner run plan tests #57304

Merged
merged 7 commits into from
Mar 10, 2025
Merged

test: refactor test runner run plan tests #57304

merged 7 commits into from
Mar 10, 2025
+295 −0

Conversation

pmarchini
Copy link
Member

This is a followup refactor related to #56765 (comment) , #56765 (comment)

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 3, 2025
@pmarchini pmarchini changed the title Test/refactor test runner plan tests test: refactor test runner run plan tests Mar 3, 2025
@pmarchini pmarchini marked this pull request as ready for review March 4, 2025 22:22
@pmarchini pmarchini added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65578/

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (8c2df73) to head (97f1057).
Report is 123 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57304      +/-   ##
==========================================
- Coverage   90.34%   90.22%   -0.13%     
==========================================
  Files         629      630       +1     
  Lines      184403   185166     +763     
  Branches    36040    36226     +186     
==========================================
+ Hits       166607   167064     +457     
- Misses      10919    11114     +195     
- Partials     6877     6988     +111

see 81 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmarchini pmarchini requested a review from atlowChemi March 5, 2025 15:10
cjihrig
cjihrig approved these changes Mar 5, 2025
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although relying on setTimeout() behavior in tests always makes me nervous.

MoLow
MoLow approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@MoLow MoLow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. added some nitpics

@pmarchini
Copy link
Member Author

LGTM, although relying on setTimeout() behavior in tests always makes me nervous.

+100 on setTimeout concerns

@pmarchini pmarchini added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1b655c7 into nodejs:main Mar 10, 2025
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b655c7

targos pushed a commit that referenced this pull request Mar 11, 2025
@pmarchini @targos
test: test runner run plan
44ca677 
PR-URL: #57304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
targos pushed a commit that referenced this pull request Mar 11, 2025
@pmarchini @targos
test: test runner run plan
b866755 
PR-URL: #57304
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actions github-actions bot mentioned this pull request Mar 12, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@MoLow MoLow MoLow approved these changes

@atlowChemi atlowChemi Awaiting requested review from atlowChemi

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pmarchini @nodejs-github-bot @cjihrig @MoLow @atlowChemi