Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: revise webcrypto.md types, interfaces, and added versions #57376

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

panva
Copy link
Member

@panva panva commented Mar 8, 2025

Having done a pass over the Webcrypto API I've noticed a couple discrepancies in the docs.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto
  • @nodejs/web-infra

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Mar 8, 2025
@panva panva added the webcrypto label Mar 8, 2025
@panva panva force-pushed the doc-webcrypto-pass branch 2 times, most recently from 66bd439 to 6e8fca2 Compare March 8, 2025 18:34
@panva panva force-pushed the doc-webcrypto-pass branch from 6e8fca2 to 7014357 Compare March 10, 2025 07:30
@panva panva changed the title doc: revised webcrypto.md doc: revise webcrypto.md types, interfaces, and added versions Mar 10, 2025
@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 10, 2025
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit rubber stampy as I haven't verified all the content, overall it LGTM

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2025
@panva
Copy link
Member Author

panva commented Mar 10, 2025

ty both

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit d8a9ab4 into nodejs:main Mar 10, 2025
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d8a9ab4

targos pushed a commit that referenced this pull request Mar 11, 2025
PR-URL: #57376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Mar 11, 2025
PR-URL: #57376
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. webcrypto
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants