dns: remove redundant code using common variable #57386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`validFamilies` variable is defined 2 times, so remove redundant code by defining `validFamilies` in util. Plus, apply the same approach to `validDnsOrders` because it's also used multiple times.
|
Review requested:
|
nodejs-github-bot
added
dns
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57386 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 630 630
Lines 185200 185206 +6
Branches 36233 36235 +2
=======================================
+ Hits 167108 167118 +10
+ Misses 11056 11051 -5
- Partials 7036 7037 +1
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Mar 9, 2025
github-actions
bot
removed
the
request-ci
daeyeon
approved these changes
Mar 10, 2025
daeyeon
added
the
author ready
Lxxyx
approved these changes
Mar 10, 2025
deokjinkim
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in baf989b |
targos
pushed a commit
that referenced
this pull request
Mar 11, 2025
`validFamilies` variable is defined 2 times, so remove redundant code by defining `validFamilies` in util. Plus, apply the same approach to `validDnsOrders` because it's also used multiple times. PR-URL: #57386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos
pushed a commit
that referenced
this pull request
Mar 11, 2025
`validFamilies` variable is defined 2 times, so remove redundant code by defining `validFamilies` in util. Plus, apply the same approach to `validDnsOrders` because it's also used multiple times. PR-URL: #57386 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validFamiliesvariable is defined 2 times, so remove redundant code by definingvalidFamiliesin util. Plus, apply the same approach tovalidDnsOrdersbecause it's also used multiple times.