Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: cleanup aliased_buffer.h #57395

Merged
merged 1 commit into from
Mar 13, 2025
Merged

src: cleanup aliased_buffer.h #57395

merged 1 commit into from
Mar 13, 2025
+24 −24

Conversation

VoltrexKeyva
Copy link
Member

  • Mark AliasedBufferBase as final as nothing derives from it.
  • Simplify scalar check with std::is_scalar_v.
  • Remove redundant const-qualifiers from function declaration parameters (see [readability-avoid-const-params-in-decls]).
  • Add const-qualifiers to function definition parameters where appropriate.
  • Remove redundant inline specifiers from functions that are templates or has template parents, and from functions that are entirely declared inside class definitions (see [readability-redundant-inline-specifier]).
  • Remove redundant template arguments.
  • Remove redundant qualified name.
  • Fix typo and improve grammar.

@VoltrexKeyva
src: cleanup aliased_buffer.h
ca26b64 
- Mark `AliasedBufferBase` as `final` as nothing derives from it.
- Simplify scalar check with `std::is_scalar_v`.
- Remove redundant `const`-qualifiers from function declaration
parameters.
- Add `const`-qualifiers to function definition parameters where
appropriate.
- Remove redundant `inline` specifiers from functions that are
templates or has template parents, and from functions that are entirely
declared inside class definitions.
- Remove redundant template arguments.
- Remove redundant qualified name.
- Fix typo and improve grammar.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 10, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (fbe37d5) to head (ca26b64).
Report is 31 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57395      +/-   ##
==========================================
+ Coverage   90.21%   90.23%   +0.01%     
==========================================
  Files         630      630              
  Lines      185213   185213              
  Branches    36240    36244       +4     
==========================================
+ Hits       167096   167120      +24     
+ Misses      11057    11042      -15     
+ Partials     7060     7051       -9
Files with missing lines Coverage Δ
src/aliased_buffer.h 100.00% <100.00%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VoltrexKeyva VoltrexKeyva added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65689/

@VoltrexKeyva VoltrexKeyva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1189a26 into nodejs:main Mar 13, 2025
71 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1189a26

@VoltrexKeyva VoltrexKeyva deleted the aliasedbuffer-cleanup branch March 13, 2025 12:38
aduh95 pushed a commit that referenced this pull request Mar 18, 2025
@VoltrexKeyva @aduh95
src: cleanup aliased_buffer.h
6a13319 
- Mark `AliasedBufferBase` as `final` as nothing derives from it.
- Simplify scalar check with `std::is_scalar_v`.
- Remove redundant `const`-qualifiers from function declaration
parameters.
- Add `const`-qualifiers to function definition parameters where
appropriate.
- Remove redundant `inline` specifiers from functions that are
templates or has template parents, and from functions that are entirely
declared inside class definitions.
- Remove redundant template arguments.
- Remove redundant qualified name.
- Fix typo and improve grammar.

PR-URL: #57395
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@VoltrexKeyva @RafaelGSS
src: cleanup aliased_buffer.h
07fc8b8 
- Mark `AliasedBufferBase` as `final` as nothing derives from it.
- Simplify scalar check with `std::is_scalar_v`.
- Remove redundant `const`-qualifiers from function declaration
parameters.
- Add `const`-qualifiers to function definition parameters where
appropriate.
- Remove redundant `inline` specifiers from functions that are
templates or has template parents, and from functions that are entirely
declared inside class definitions.
- Remove redundant template arguments.
- Remove redundant qualified name.
- Fix typo and improve grammar.

PR-URL: #57395
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@VoltrexKeyva @RafaelGSS
src: cleanup aliased_buffer.h
fa7d917 
- Mark `AliasedBufferBase` as `final` as nothing derives from it.
- Simplify scalar check with `std::is_scalar_v`.
- Remove redundant `const`-qualifiers from function declaration
parameters.
- Add `const`-qualifiers to function definition parameters where
appropriate.
- Remove redundant `inline` specifiers from functions that are
templates or has template parents, and from functions that are entirely
declared inside class definitions.
- Remove redundant template arguments.
- Remove redundant qualified name.
- Fix typo and improve grammar.

PR-URL: #57395
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@VoltrexKeyva @nodejs-github-bot @jasnell @addaleax @aduh95