Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch: check parent and child path properly #57425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jazelly
Copy link
Member

@jazelly jazelly commented Mar 12, 2025

Fixes: #57422

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 12, 2025
@jazelly jazelly force-pushed the fix-57422 branch 3 times, most recently from bb7f643 to 7a81702 Compare March 12, 2025 14:26
@jakecastelli jakecastelli added the watch-mode Issues and PRs related to watch mode label Mar 12, 2025
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (59f00d7) to head (7a81702).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/watch_mode/files_watcher.js 90.90% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #57425   +/-   ##
=======================================
  Coverage   90.21%   90.22%           
=======================================
  Files         629      629           
  Lines      185126   185142   +16     
  Branches    36225    36232    +7     
=======================================
+ Hits       167016   167044   +28     
+ Misses      11055    11048    -7     
+ Partials     7055     7050    -5     
Files with missing lines Coverage Δ
lib/internal/watch_mode/files_watcher.js 89.20% <90.90%> (-0.07%) ⬇️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

co-authored-by: Jake Yuesong Li <jake.yuesong@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. watch-mode Issues and PRs related to watch mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch not working on paths with overlap
4 participants