Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make minor cleanups in multiple files #57448

Closed
wants to merge 2 commits into from
Closed

src: make minor cleanups in multiple files #57448

wants to merge 2 commits into from
+37 −29

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 13, 2025

Eliminating some extraneous v8: qualifiers.

@jasnell jasnell requested a review from anonrig March 13, 2025 21:42
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 13, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65728/

@nodejs-github-bot

This comment was marked as duplicate.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Mar 13, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 94.11765% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.22%. Comparing base (b71267e) to head (cd9770c).
Report is 18 commits behind head on main.

Files with missing lines Patch % Lines
src/encoding_binding.cc 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57448      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         629      629              
  Lines      184937   184936       -1     
  Branches    36205    36211       +6     
==========================================
- Hits       166881   166858      -23     
- Misses      11039    11041       +2     
- Partials     7017     7037      +20
Files with missing lines Coverage Δ
src/compile_cache.cc 80.78% <100.00%> (-0.07%) ⬇️
src/encoding_binding.cc 78.45% <66.66%> (ø)

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 13, 2025
RaisinTen
RaisinTen reviewed Mar 14, 2025
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title could be edited to also include encoding_binding.cc

@jasnell jasnell force-pushed the jasnell/minor-cleanups branch from 29a0940 to cd9770c Compare March 14, 2025 16:44
@jasnell jasnell changed the title src: make minor cleanups in compile_cache.cc src: make minor cleanups in multiple files Mar 14, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65752/

jasnell added a commit that referenced this pull request Mar 16, 2025
@jasnell
src: make minor cleanups in compile_cache.cc
387b8cb 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
jasnell added a commit that referenced this pull request Mar 16, 2025
@jasnell
src: make minor cleanups in encoding_binding.cc
fb07807 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Mar 16, 2025

Landed in fef180c...fb07807

@jasnell jasnell closed this Mar 16, 2025
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@jasnell @aduh95
src: make minor cleanups in compile_cache.cc
f8acf2d 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@jasnell @aduh95
src: make minor cleanups in encoding_binding.cc
b9d9ee4 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@jasnell @RafaelGSS
src: make minor cleanups in compile_cache.cc
96a6a2e 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@jasnell @RafaelGSS
src: make minor cleanups in encoding_binding.cc
94106c3 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@jasnell @RafaelGSS
src: make minor cleanups in compile_cache.cc
dabbd0e 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
RafaelGSS pushed a commit that referenced this pull request Apr 1, 2025
@jasnell @RafaelGSS
src: make minor cleanups in encoding_binding.cc
cf7d7cb 
PR-URL: #57448
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@benjamingr benjamingr benjamingr approved these changes

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jasnell @nodejs-github-bot @benjamingr @lpinca @anonrig @juanarbol @RaisinTen