doc: remove typo YAML snippet from tls.getCACertificates doc #57459
+0
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed it while going through https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399, so thought of removing it. Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
added
doc
aduh95
approved these changes
Mar 14, 2025
aduh95
added
the
author ready
lpinca
approved these changes
Mar 14, 2025
aduh95
added
the
commit-queue
jasnell
approved these changes
Mar 14, 2025
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57459 ✔ Done loading data for nodejs/node/pull/57459 ----------------------------------- PR info ------------------------------------ Title doc: remove typo YAML snippet from tls.getCACertificates doc (#57459) Author Darshan Sen <raisinten@gmail.com> (@RaisinTen) Branch RaisinTen:doc/remove-typo-YAML-snippet-from-getCACertificates-doc -> nodejs:main Labels tls, doc, fast-track, author ready Commits 1 - doc: remove typo YAML snippet from tls.getCACertificates doc Committers 1 - Darshan Sen <raisinten@gmail.com> PR-URL: https://github.com/nodejs/node/pull/57459 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57459 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Mar 2025 13:06:10 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57459#pullrequestreview-2685482845 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57459#pullrequestreview-2686168107 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57459#pullrequestreview-2686256782 ℹ This PR is being fast-tracked ✘ This PR needs to wait 43 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13861953218 |
RaisinTen
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d765e70 |
RaisinTen
deleted the
doc/remove-typo-YAML-snippet-from-getCACertificates-doc
branch
aduh95
pushed a commit
that referenced
this pull request
Mar 18, 2025
Noticed it while going through https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399, so thought of removing it. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #57459 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
Noticed it while going through https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399, so thought of removing it. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #57459 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
Apr 1, 2025
Noticed it while going through https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399, so thought of removing it. Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #57459 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed it while going through
https://github.com/nodejs/node/pull/57107/files#diff-6114e55c49ec9bc0edc33830f7770a335a46373a84b8372957c387d88a23b7deR2399, so thought of removing it.