src: cache urlpattern properties #57465
Closed
+22
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
JonasBa
force-pushed
the
jb/urlpattern/cache-urlpattern-values
branch
from
dd09c80 to
92bd6b0
Compare
jasnell
reviewed
Mar 14, 2025
JonasBa
force-pushed
the
jb/urlpattern/cache-urlpattern-values
branch
2 times, most recently
from
f049360 to
c43db3e
Compare
|
@JonasBa can you rebase? |
JonasBa
force-pushed
the
jb/urlpattern/cache-urlpattern-values
branch
from
c43db3e to
6b48b08
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #57465 +/- ##
=======================================
Coverage 90.22% 90.23%
=======================================
Files 629 629
Lines 184845 184846 +1
Branches 36205 36212 +7
=======================================
+ Hits 166784 166790 +6
+ Misses 11016 11014 -2
+ Partials 7045 7042 -3
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Mar 18, 2025
anonrig
approved these changes
Mar 18, 2025
anonrig
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57465 ✔ Done loading data for nodejs/node/pull/57465 ----------------------------------- PR info ------------------------------------ Title src: cache urlpattern properties (#57465) Author Jonas <jonas@badalic.com> (@JonasBa) Branch JonasBa:jb/urlpattern/cache-urlpattern-values -> nodejs:main Labels c++, whatwg-url, author ready, needs-ci Commits 2 - src: cache urlpattern properties - fixup! src: cache urlpattern properties Committers 1 - JonasBa <jonas@badalic.com> PR-URL: https://github.com/nodejs/node/pull/57465 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57465 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Mar 2025 17:38:04 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57465#pullrequestreview-2694662353 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/57465#pullrequestreview-2694673339 ✔ - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/57465#pullrequestreview-2699142915 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-03-18T13:55:37Z: https://ci.nodejs.org/job/node-test-pull-request/65823/ - Querying data for job/node-test-pull-request/65823/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/13951301572 |
anonrig
pushed a commit
that referenced
this pull request
Mar 19, 2025
PR-URL: #57465 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
|
Landed in 015cd20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cache urlpattern instance properties.
This PR is stacked on top of #57452, and will be converted to ready for review once but the base lands