Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timers: remove unnecessary allocation of _onTimeout #57497

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

timers: remove unnecessary allocation of _onTimeout #57497

wants to merge 1 commit into from

Conversation

gurgunday
Copy link
Contributor

This doesn't cause that problem anymore

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout. labels Mar 16, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (8a5a849) to head (8fe22b2).
Report is 9 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57497   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         629      629           
  Lines      184847   184844    -3     
  Branches    36207    36208    +1     
=======================================
+ Hits       166780   166787    +7     
- Misses      11015    11023    +8     
+ Partials     7052     7034   -18
Files with missing lines Coverage Δ
lib/internal/timers.js 99.58% <ø> (-0.01%) ⬇️

... and 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@anonrig anonrig added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65784/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@anonrig anonrig anonrig approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. timers Issues and PRs related to the timers subsystem / setImmediate, setInterval, setTimeout.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gurgunday @nodejs-github-bot @jasnell @anonrig