Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debugger: fix behavior of plain object exec in debugger repl #57498

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Contributor

Fixes: #46808

(PS: this is a continuation of #46924 which has been stale for almost a year at this point)

dario-piotrowicz and others added 2 commits March 16, 2025 11:17
Co-authored-by: Xuguang Mei <meixuguang@gmail.com>
add `isObjectLiteral` function to share logic
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Mar 16, 2025
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a small perf improvement.

Copy link

codecov bot commented Mar 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (824c6a5) to head (0804e77).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57498      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.02%     
==========================================
  Files         629      629              
  Lines      184955   184867      -88     
  Branches    36215    36217       +2     
==========================================
- Hits       166901   166789     -112     
- Misses      11012    11029      +17     
- Partials     7042     7049       +7     
Files with missing lines Coverage Δ
lib/internal/debugger/inspect_repl.js 91.76% <100.00%> (+0.05%) ⬆️
lib/internal/repl/utils.js 96.34% <100.00%> (+0.08%) ⬆️
lib/repl.js 94.89% <100.00%> (-0.02%) ⬇️

... and 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

… repl

move regexes outside of `isObjectLiteral`
@anonrig anonrig added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different behavior of { a: 1 } in the REPL and the debugger
4 participants