Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: add some clarification to the nomination process #57503

Closed
wants to merge 3 commits into from
Closed

meta: add some clarification to the nomination process #57503

wants to merge 3 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 16, 2025

Alternative to some of the other PRs on this... Some of the language here was adopted directly from one of @Trott's comments in the discussion

@nodejs/tsc

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Mar 16, 2025
@jasnell jasnell mentioned this pull request Mar 16, 2025
Open
ronag
ronag approved these changes Mar 16, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 16, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 16, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 16, 2025
View reviewed changes
mcollina
mcollina approved these changes Mar 16, 2025
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

ShogunPanda
ShogunPanda reviewed Mar 17, 2025
View reviewed changes
GOVERNANCE.md Outdated

Explicit opposition would typically be signaled as some form of clear
and unambiguous comment like, "I don't believe this nomination should pass"
or use of the thumbs-down emoji reaction. _Ideally_ these would be paired
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would say "these must be paired".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it is "must" instead of "would" or "should", then "Ideally" also needs to be removed.

Copy link
Member Author

@jasnell jasnell Mar 22, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think "must" is necessary here so long as it is clear that the objection can be overridden if the strong recommendation is not followed. The impact ends up being the same.

ShogunPanda
ShogunPanda approved these changes Mar 17, 2025
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legendecas legendecas mentioned this pull request Mar 18, 2025
Merged
@RaisinTen
Copy link
Member

This needs a rebase

@jasnell jasnell force-pushed the jasnell/nomination-clarifications branch from f180d2e to 3e9a565 Compare March 21, 2025 17:05
@jasnell
Copy link
Member Author

jasnell commented Mar 21, 2025

All, please take another good look at the changes proposed here as there are a number of substantive changes/additions

aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
@jasnell jasnell force-pushed the jasnell/nomination-clarifications branch from 3e9a565 to 4cac61d Compare March 21, 2025 17:45
aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
ljharb
ljharb approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to @aduh95's comments as well

aduh95
aduh95 reviewed Mar 21, 2025
View reviewed changes
@jasnell jasnell force-pushed the jasnell/nomination-clarifications branch from 5e8aa66 to c0bf926 Compare March 21, 2025 18:59
@jasnell jasnell requested review from aduh95 and Trott March 21, 2025 18:59
aduh95
aduh95 approved these changes Mar 21, 2025
View reviewed changes
RaisinTen
RaisinTen approved these changes Mar 22, 2025
View reviewed changes
@jasnell jasnell force-pushed the jasnell/nomination-clarifications branch from c0bf926 to eae6987 Compare March 22, 2025 14:12
@jasnell
Copy link
Member Author

jasnell commented Mar 22, 2025

Will land on Monday if there are no further comments to address.

ovflowd
ovflowd reviewed Mar 22, 2025
View reviewed changes
ovflowd
ovflowd reviewed Mar 22, 2025
View reviewed changes
GOVERNANCE.md
along with signals indicating commitment to Node.js, personal integrity, etc.,
should be enough for a successful nomination.

It is important to understand that potential collaborators may have vastly
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell can you please add a section describing examples of what a potential collaborator candidate would be? What are contributions we should look for? Creating a baseline will help a lot of people to not feel uncomfortable doing so!

ovflowd
ovflowd approved these changes Mar 22, 2025
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate this is happening.

ovflowd
ovflowd reviewed Mar 22, 2025
View reviewed changes
This was referenced Mar 22, 2025
Closed
Closed
jasnell
jasnell commented Mar 24, 2025
View reviewed changes
jasnell added a commit that referenced this pull request Mar 24, 2025
@jasnell
meta: add some clarification to the nomination process
f95e43e 
Update GOVERNANCE.md

PR-URL: #57503
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@jasnell
Copy link
Member Author

jasnell commented Mar 24, 2025

Landed in f95e43e

@jasnell jasnell closed this Mar 24, 2025
aduh95 pushed a commit that referenced this pull request Mar 25, 2025
@jasnell @aduh95
meta: add some clarification to the nomination process
00a5b18 
Update GOVERNANCE.md

PR-URL: #57503
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
pandeykushagra51 pushed a commit to pandeykushagra51/node that referenced this pull request Mar 28, 2025
@jasnell @pandeykushagra51
meta: add some clarification to the nomination process
6bf0c43 
Update GOVERNANCE.md

PR-URL: nodejs#57503
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Ruy Adorno <ruy@vlt.sh>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@github-actions github-actions bot mentioned this pull request Mar 30, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@aduh95 aduh95 aduh95 approved these changes

@ovflowd ovflowd ovflowd approved these changes

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

@ljharb ljharb ljharb approved these changes

@anonrig anonrig anonrig approved these changes

@ronag ronag ronag approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@MoLow MoLow MoLow approved these changes

@ruyadorno ruyadorno ruyadorno approved these changes

@H4ad H4ad H4ad approved these changes

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@trivikr trivikr trivikr approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

@mcollina mcollina mcollina approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.