Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make more error handling improvements #57507

Closed
wants to merge 4 commits into from
Closed

src: make more error handling improvements #57507

wants to merge 4 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Mar 16, 2025

No description provided.

@jasnell jasnell requested a review from anonrig March 16, 2025 21:57
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/http2
  • @nodejs/net
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65790/

@codecov Codecov
Copy link

codecov bot commented Mar 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.85714% with 13 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (0cfc471) to head (5de75f0).
Report is 29 commits behind head on main.

Files with missing lines Patch % Lines
src/node_builtins.cc 59.09% 0 Missing and 9 partials ⚠️
src/node_http2.cc 62.50% 1 Missing and 2 partials ⚠️
src/node_http_parser.cc 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57507      +/-   ##
==========================================
+ Coverage   90.21%   90.23%   +0.01%     
==========================================
  Files         629      629              
  Lines      184845   184843       -2     
  Branches    36206    36205       -1     
==========================================
+ Hits       166766   166788      +22     
+ Misses      11024    11020       -4     
+ Partials     7055     7035      -20
Files with missing lines Coverage Δ
src/node_http_parser.cc 83.02% <80.00%> (-0.09%) ⬇️
src/node_http2.cc 85.07% <62.50%> (+0.21%) ⬆️
src/node_builtins.cc 79.12% <59.09%> (+1.37%) ⬆️

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 17, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65818/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/65826/

jasnell added a commit that referenced this pull request Mar 20, 2025
@jasnell
src: improve error handling in multiple files
3641d33 
* node_http_parser
* node_http2
* node_builtins

PR-URL: #57507
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Mar 20, 2025

Landed in 3641d33

@jasnell jasnell closed this Mar 20, 2025
aduh95 pushed a commit that referenced this pull request Mar 23, 2025
@jasnell @aduh95
src: improve error handling in multiple files
9611980 
* node_http_parser
* node_http2
* node_builtins

PR-URL: #57507
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@daeyeon daeyeon daeyeon approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jasnell @nodejs-github-bot @anonrig @UlisesGascon @daeyeon @legendecas