New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mark multiple long-time experimental APIs as stable #57510

Closed

jasnell wants to merge 9 commits into nodejs:main from jasnell:jasnell/als-apis-non-experimental

+88 −44

Member

jasnell commented Mar 16, 2025

These have been stable for a while now

jasnell added 5 commits

March 16, 2025 16:45


          doc: make AsyncLocalStorage snapshot and bind APIs non-experimental

a8c218c

These have been stable for a while now


          doc: remove the experimental status for multiple web streams apis

e64f6cc


          doc: mark the MIMEUtil API stable

17a20ed


          doc: mark tracing module stable

7a7ea42


          doc: mark transferable AbortSignal/Controller stable

f086155

nodejs-github-bot added the doc label

jasnell commented

View reviewed changes

doc/api/async_context.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/async_context.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/globals.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/util.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/util.md Outdated Show resolved Hide resolved

jasnell commented

View reviewed changes

doc/api/util.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

ebc8286

jasnell requested a review from mcollina

March 17, 2025 00:07

jasnell requested a review from anonrig

March 17, 2025 00:07

anonrig approved these changes

View reviewed changes

aduh95 reviewed

View reviewed changes

doc/api/tracing.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

a6fb292

Co-authored-by: Antoine du Hamel <duhamelantoine1995@gmail.com>

aduh95 approved these changes

View reviewed changes

Contributor

aduh95 left a comment

I can't vouch for each API here, but given the length of the experimental period, LGTM

mcollina approved these changes

View reviewed changes

Member

mcollina left a comment

lgtm

Member

marco-ippolito commented Mar 17, 2025

Instead of removing the stability index change it to

> Stability: 2 - Stable

Contributor

aduh95 commented Mar 17, 2025

Instead of removing the stability index change it to
> Stability: 2 - Stable

Only for tracing.md, the others inherit the stable status already

legendecas reviewed

View reviewed changes

doc/api/tracing.md Outdated Show resolved Hide resolved

legendecas requested changes

View reviewed changes

Member

legendecas left a comment

LGTM to mark most of the APIs in this PR as stable, except for the trace event module.

Additionally, the trace event module documents that it does not work for worker threads. This is not a good state to mark it as stable.

jasnell commented

View reviewed changes

doc/api/tracing.md Outdated Show resolved Hide resolved


          Update doc/api/tracing.md

c9847ef

jasnell commented

View reviewed changes

doc/api/tracing.md Outdated Show resolved Hide resolved


          Update doc/api/tracing.md

9c3d8b5

jasnell requested a review from legendecas

March 18, 2025 13:58

legendecas approved these changes

View reviewed changes

Member

legendecas commented Mar 18, 2025

Thanks!

jasnell added a commit that referenced this pull request


          doc: mark multiple experimental APIS as stable

* AsyncLocalStorage snapshot and bind APIs
* multiple web streams apis
* MIMEType API
* Transferable AbortSignal/Controller

PR-URL: #57510
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Member Author

jasnell commented Mar 20, 2025

Landed in 9640379

jasnell closed this

aduh95 pushed a commit that referenced this pull request


          doc: mark multiple experimental APIS as stable

87e0dda

* AsyncLocalStorage snapshot and bind APIs
* multiple web streams apis
* MIMEType API
* Transferable AbortSignal/Controller

PR-URL: #57510
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

github-actions bot mentioned this pull request

2025-03-31, Version 23.11.0 (Current) #57694

Merged

RafaelGSS pushed a commit that referenced this pull request


          doc: mark multiple experimental APIS as stable

61cb3a9

* AsyncLocalStorage snapshot and bind APIs
* multiple web streams apis
* MIMEType API
* Transferable AbortSignal/Controller

PR-URL: #57510
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

RafaelGSS pushed a commit that referenced this pull request


          doc: mark multiple experimental APIS as stable

c33fffe

* AsyncLocalStorage snapshot and bind APIs
* multiple web streams apis
* MIMEType API
* Transferable AbortSignal/Controller

PR-URL: #57510
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc