Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
src: add
--run-from
runtime flag #57523base: main
Are you sure you want to change the base?
src: add
--run-from
runtime flag #57523Changes from all commits
4416cc0
b93de16
d08981b
f374130
94717dd
6e5d7d5
7b23a7d
6194d3d
fc6a438
d4aa938
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this change the working directory of the Node process, or is it only about where to find the
package.json
file?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It sets the Node process's working directory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm... the naming here was discussed in the linked issue. The name
run-dir
was suggested in the case that the option only set the cwd for the run command. If we're going to have this generally set the cwd for the process then it should definitely be named something elseThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That said, the documentation update would imply that it only works with the
--run
command.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it has a more general effect of setting the initial cwd for the process, and assuming we are ok with such a flag, I think it should be named
--cwd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the use case for setting the initial cwd for the process? Aside from telling Node where to find
package.json
, which could be done with a more isolated flag.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will not work since this doesn't add the current node_modules to path environment variable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@anonrig I tried to process the path given with --run-from and add the
node_modules/.bin
directory under the cwd to thePATH
Without changing the cwd of the parent process, only the cwd of the spawned process will be set, is this a good solution ?