esm: WebAssembly.Global unwrapping for Wasm Namespaces #57525
+479
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
esm
guybedford
force-pushed
the
wasm-globals-ns-unwrapping
branch
from
2565b77 to
610b7dd
Compare
guybedford
force-pushed
the
wasm-globals-ns-unwrapping
branch
from
610b7dd to
0f49b0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft PR implementing a Wasm ESM Integration PR for global unwrapping in WebAssembly/esm-integration#104.
Opening here as a draft only for feedback and discussion, as it helps to have a concrete implementation for understanding and experimentation.
With this change, WebAssembly namespaces exporting globals have the global value provided directly on the namespace exports, instead of exporting
WebAssembly.Globalrequiring aglobal.valuegetter access in turn to retrieve the underlying binding. With this, Wasm namespaces can effectively export any JS binding type when using Wasm GC, instead of justMemory,Table,FunctionandGlobal.We do this by unwrapping the global on the Wasm namespace exports interface, while still linking Wasm - Wasm imports to the underlying global. Ideally this would support live exported bindings as well, but that would require V8 work in turn.