Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update amaro to 0.5.0 #57598

Closed
wants to merge 1 commit into from
Closed

deps: update amaro to 0.5.0 #57598

wants to merge 1 commit into from
+35 −14

Conversation

nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot nodejs-github-bot commented Mar 23, 2025 •
edited
Loading

This is an automated update of amaro to 0.5.0.

@nodejs-github-bot nodejs-github-bot added dependencies Pull requests that update a dependency file. strip-types Issues or PRs related to strip-types support labels Mar 23, 2025
@nodejs-github-bot
Copy link
Collaborator Author

nodejs-github-bot commented Mar 23, 2025 •
edited by marco-ippolito
Loading

Review requested:

  • @nodejs/security-wg
  • @nodejs/typescript
  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Mar 23, 2025
@marco-ippolito marco-ippolito marked this pull request as draft March 23, 2025 17:12
@marco-ippolito marco-ippolito added the wip Issues and PRs that are still a work in progress. label Mar 23, 2025
@marco-ippolito marco-ippolito self-assigned this Mar 23, 2025
@marco-ippolito marco-ippolito changed the title deps: update amaro to 0.5.0 module: improve typescript error message format Mar 23, 2025
@marco-ippolito marco-ippolito added the module Issues and PRs related to the module subsystem. label Mar 23, 2025
@marco-ippolito marco-ippolito marked this pull request as ready for review March 23, 2025 18:24
@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 23, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.22%. Comparing base (af75d04) to head (6c298bc).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57598      +/-   ##
==========================================
- Coverage   90.23%   90.22%   -0.01%     
==========================================
  Files         630      630              
  Lines      185055   185055              
  Branches    36221    36216       -5     
==========================================
- Hits       166984   166970      -14     
- Misses      11043    11046       +3     
- Partials     7028     7039      +11

see 18 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito mentioned this pull request Mar 26, 2025
Closed
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65889/

@marco-ippolito marco-ippolito mentioned this pull request Mar 26, 2025
Closed
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65895/

@aduh95 aduh95 removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 28, 2025
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/65896/

@nodejs-github-bot @github-actions
deps: update amaro to 0.5.0

Verified

This commit was signed with the committer’s verified signature.
AzureMarker Mark Drobnak
GPG key ID: 47A133F3BF9D03D3
Verified
Learn about vigilant mode
6c298bc
@nodejs-github-bot nodejs-github-bot force-pushed the actions/tools-update-amaro branch from e9ea0c6 to 6c298bc Compare March 30, 2025 00:36
@nodejs-github-bot nodejs-github-bot changed the title module: improve typescript error message format deps: update amaro to 0.5.0 Mar 30, 2025
@marco-ippolito marco-ippolito mentioned this pull request Mar 30, 2025
Closed
@marco-ippolito
Copy link
Member

superseded by #57687

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legendecas legendecas

@aduh95 aduh95

@RafaelGSS RafaelGSS

Assignees

@marco-ippolito marco-ippolito

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. lib / src Issues and PRs related to general changes in the lib or src directory. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. strip-types Issues or PRs related to strip-types support wip Issues and PRs that are still a work in progress.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nodejs-github-bot @marco-ippolito @legendecas @aduh95 @RafaelGSS