doc: remove Corepack documentation #57635
Merged
+4
−181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Mar 26, 2025
himself65
approved these changes
Mar 26, 2025
aduh95
added
the
author ready
atlowChemi
approved these changes
Mar 26, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57635 +/- ##
==========================================
- Coverage 90.22% 90.22% -0.01%
==========================================
Files 630 630
Lines 185055 185055
Branches 36216 36219 +3
==========================================
- Hits 166975 166968 -7
- Misses 11042 11044 +2
- Partials 7038 7043 +5 🚀 New features to boost your workflow:
|
gurgunday
reviewed
Mar 26, 2025
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
trivikr
approved these changes
Mar 27, 2025
RaisinTen
approved these changes
Mar 27, 2025
lpinca
approved these changes
Mar 27, 2025
aduh95
added
the
commit-queue
aymen94
approved these changes
Mar 27, 2025
bjohansebas
approved these changes
Mar 27, 2025
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/57635 ✔ Done loading data for nodejs/node/pull/57635 ----------------------------------- PR info ------------------------------------ Title doc: remove Corepack documentation (#57635) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:remove-corepack-docs -> nodejs:main Labels doc, author ready Commits 3 - doc: remove Corepack documentation - fixup! doc: remove Corepack documentation - Update doc/api/corepack.md Committers 2 - Antoine du Hamel <duhamelantoine1995@gmail.com> - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/57635 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/57635 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 26 Mar 2025 13:29:55 GMT ✔ Approvals: 6 ✔ - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/57635#pullrequestreview-2717765062 ✔ - Zeyu "Alex" Yang (@himself65): https://github.com/nodejs/node/pull/57635#pullrequestreview-2718194231 ✔ - Chemi Atlow (@atlowChemi): https://github.com/nodejs/node/pull/57635#pullrequestreview-2718481484 ✔ - Trivikram Kamat (@trivikr): https://github.com/nodejs/node/pull/57635#pullrequestreview-2719617210 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/57635#pullrequestreview-2719981595 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57635#pullrequestreview-2720110385 ✔ Last GitHub CI successful ✘ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/14130077013 |
|
Landed in af75d04 |
aduh95
added a commit
that referenced
this pull request
Mar 28, 2025
PR-URL: #57635 Reviewed-By: Jordan Harband <ljharb@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com> Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping the
corepack.mdfile so this can be backported without returning 404 in case there are links in the wild. I'll open a follow-up that removes it which should not be backported.The reason for this is that the documentation is outdated and not well maintained, and Node.js TSC has decided Corepack won't be distributed on future release lines.