Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix javascript tests in CI #4009

Closed
kevaundray opened this issue Jan 11, 2024 · 1 comment · Fixed by #4014 or #4022
Closed

Fix javascript tests in CI #4009

kevaundray opened this issue Jan 11, 2024 · 1 comment · Fixed by #4014 or #4022
Assignees
@Thunkar @TomAFrench
Labels
enhancement New feature or request

Comments

@kevaundray
Copy link
Contributor

kevaundray commented Jan 11, 2024 •
edited
Loading

Problem

Javascript tests are currently failing as of this commit

Happy Case

.

Alternatives Considered

No response

Additional Context

No response

Would you like to submit a PR for this Issue?

No

Support Needs

No response
@kevaundray kevaundray added the enhancement New feature or request label Jan 11, 2024
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Noir Jan 11, 2024
@TomAFrench TomAFrench mentioned this issue Jan 11, 2024
Merged
5 tasks
kevaundray pushed a commit that referenced this issue Jan 11, 2024
@TomAFrench
chore(ci): fix docker CI (#4014)
37272b9 
# Description

## Problem\*

Resolves #4009 

## Summary\*

Aiming to be the dumbest way to get CI passing again.

## Additional Context



## Documentation\*

Check one:
- [ ] No documentation needed.
- [ ] Documentation included in this PR.
- [ ] **[Exceptional Case]** Documentation to be submitted in a separate
PR.

# PR Checklist\*

- [ ] I have tested the changes locally.
- [ ] I have formatted the changes with [Prettier](https://prettier.io/)
and/or `cargo fmt` on default settings.
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Noir Jan 11, 2024
@TomAFrench TomAFrench reopened this Jan 11, 2024
@TomAFrench
Copy link
Member

This is still broken

@TomAFrench TomAFrench linked a pull request Jan 11, 2024 that will close this issue
fix: fixup exports from noir_wasm #4022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Thunkar Thunkar

@TomAFrench TomAFrench

Labels
enhancement New feature or request
Projects
Noir
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ci): fix docker CI noir-lang/noir
fix: fixup exports from noir_wasm noir-lang/noir
3 participants
@Thunkar @TomAFrench @kevaundray