fix: de-duplicate public inputs in BB proofs #4937
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #4443
Summary*
Barretenberg append public inputs to the proof, which are removed in Noir and prepended again before verification.
However in Noir duplicate witnesses are removed, although not in Barretenberg, which generates a discrepancy.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmt
on default settings.