Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent panic within remove_possibly_mutated_cached_make_arrays #7264

Merged
merged 4 commits into from
Feb 3, 2025
Merged

fix: prevent panic within remove_possibly_mutated_cached_make_arrays #7264

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4941837
fix: prevent panic within `remove_possibly_mutated_cached_make_arrays`
TomAFrench Feb 3, 2025
43d3748
.
TomAFrench Feb 3, 2025
303e396
.
TomAFrench Feb 3, 2025
7eb871f
Update compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs
TomAFrench Feb 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions compiler/noirc_evaluator/src/ssa/opt/constant_folding.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,6 +725,11 @@ impl<'brillig> Context<'brillig> {

// Should we consider calls to slice_push_back and similar to be mutating operations as well?
if let Store { value: array, .. } | ArraySet { array, .. } = instruction {
if function.dfg.is_global(*array) {
// Early return as we expect globals to be immutable.
return;
};

let instruction = match &function.dfg[*array] {
Value::Instruction { instruction, .. } => &function.dfg[*instruction],
_ => return,
Expand Down
Loading