Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: Only decrement the counter of an array if its address has not changed #7297

Merged
merged 21 commits into from
Feb 13, 2025
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix clippy
aakoshh committed Feb 6, 2025

Verified

This commit was signed with the committer’s verified signature.
aakoshh Akosh Farkash
commit 65828859ff4d22db94b62cc3e3d9c4d348024208
Original file line number Diff line number Diff line change
@@ -874,7 +874,7 @@ impl<'block, Registers: RegisterAllocator> BrilligBlock<'block, Registers> {
};

if array_register == orig_array_register {
codegen_dec_rc(&mut self.brillig_context);
codegen_dec_rc(self.brillig_context);
} else {
// Check if the current and original register point at the same memory.
// If they don't, it means that an array-copy procedure has created a