Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove rust analyzer toolchain override #7576

Closed
wants to merge 1 commit into from

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Mar 4, 2025

Description

Problem*

No issue but failures I am getting locally with rust-analyzer post the MSRV bump in #7530.

With the repo as it is on master, rust-analyzer fails to start with like such:

2025-03-04T14:11:12.770492256Z ERROR FetchWorkspaceError: rust-analyzer failed to load workspace: Failed to load the project at /mnt/user-data/maxim/noir/Cargo.toml: Failed to read Cargo metadata from Cargo.toml file /mnt/user-data/maxim/noir/Cargo.toml, Some(Version { major: 1, minor: 84, patch: 1 }): Failed to run `cd "/mnt/user-data/maxim/noir" && RUSTUP_TOOLCHAIN="/opt/rust/rustup/toolchains/stable-x86_64-unknown-linux-gnu" "/mnt/user-data/maxim/.cargo/bin/cargo" "metadata" "--format-version" "1" "--manifest-path" "/mnt/user-data/maxim/noir/Cargo.toml" "--filter-platform" "x86_64-unknown-linux-gnu"`: `cargo metadata` exited with an error: error: failed to load manifest for workspace member `/mnt/user-data/maxim/noir/compiler/noirc_arena`
referenced by workspace at `/mnt/user-data/maxim/noir/Cargo.toml`

Caused by:
  failed to parse manifest at `/mnt/user-data/maxim/noir/compiler/noirc_arena/Cargo.toml`

Caused by:
  feature `edition2024` is required

  The package requires the Cargo feature called `edition2024`, but that feature is not stabilized in this version of Cargo (1.84.1 (66221abde 2024-11-19)).
  Consider trying a newer version of Cargo (this may require the nightly release).
  See https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#edition-2024 for more information about the status of this feature.


[Error - 2:11:25 PM] Server process exited with code 0.

It looks that the stable toolchain from "rust-analyzer.server.extraEnv": { "RUSTUP_TOOLCHAIN": "stable" } is actually 1.84.1 and not 1.85.0.

Summary*

Turning off the above setting got rust-analyzer working normally again.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm
Copy link
Contributor Author

vezenovm commented Mar 4, 2025

After a clean uninstall and re-installation of Rust (https://www.rust-lang.org/tools/install) my analyzer starting working again, so going to close for now.

@vezenovm vezenovm closed this Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant