fix: Experiment with DecrementRc
#7629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 19c19c0 | Previous: e3f8398 | Ratio |
|---|---|---|---|
AztecProtocol_aztec-packages_noir-projects_noir-contracts |
99 s |
77 s |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
|
Opening this to review because I think this solves the original issue which #7297 patched. As far as I can see performance with this PR is similar to before it, although ref counts are slightly different depending on inliner settings. |
vezenovm
reviewed
Mar 17, 2025
test_programs/execution_success/reference_counts_inliner_0/src/main.nr
Outdated
Show resolved
Hide resolved
compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Maxim Vezenov <mvezenov@gmail.com>
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
This was referenced Mar 18, 2025
vezenovm
approved these changes
Mar 18, 2025
aakoshh
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Mar 19, 2025
Automated pull of nightly from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: add `mapi`/`for_eachi` functions (noir-lang/noir#7705) fix: Experiment with `DecrementRc` (noir-lang/noir#7629) chore: delete honk programs from `test_programs` (noir-lang/noir#7727) chore(docs): Landing page jargonless intro (noir-lang/noir#7649) chore(docs): More acir docs (noir-lang/noir#7731) chore: add extra docs lint (noir-lang/noir#7742) fix: Fix stdout testing when running test programs (noir-lang/noir#7741) chore(ci): enforce rustdoc lints (noir-lang/noir#7738) chore: bump bb (noir-lang/noir#7726) fix: handle predicate value reduction in array get also for the databus (noir-lang/noir#7730) chore(refactor): Move resolved error structures out of acir crate (noir-lang/noir#7734) chore(ci): private-kernel-inner timeout bump (noir-lang/noir#7732) END_COMMIT_OVERRIDE --------- Co-authored-by: aakoshh <akosh@aztecprotocol.com> Co-authored-by: Akosh Farkash <aakoshh@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This is an experimental branch where I'm hoping to fix the underlying issues with our usage of
dec_rc. Currently this PR:dec_rc value original_valueback to a single valueddec_rc valuedec_rcon parameters to always be issued on the original load value rather than creating a new load. This should fix the original underflow issue we changed dec_rc for.reference_countsinto a separate test for each inliner setting: min, 0, and max. The inliner0setting was actually seeing different optimization characteristics compared to the other two just due to optimization ordering. The behavior is still correct though.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.