feat: ssa fuzzer #7641
feat: ssa fuzzer #7641
Conversation
tooling/ssa_fuzzer/src/builder.rs
Outdated
|
|
||
| /// Inserts an add instruction between two values | ||
| pub fn insert_add_instruction(&mut self, lhs: Id<Value>, rhs: Id<Value>) -> Id<Value> { | ||
| let result = self.builder.insert_binary(lhs, BinaryOp::Add { unchecked: false }, rhs); |
There was a problem hiding this comment.
Checked/Unchecked should be parameterized, too
| pub mod compiler; | ||
| pub mod config; | ||
| pub mod helpers; | ||
| pub mod runner; |
There was a problem hiding this comment.
COuld you please add tests checking the correctness of all simple instructions (additions, etc). Run in both modes and check results
| } | ||
|
|
||
| /// Checks if two indices exist in both ACIR and Brillig witness vectors | ||
| fn both_indeces_presented( |
There was a problem hiding this comment.
Rename to "index_exists_in_both_witness_vectors"
| } | ||
|
|
||
| /// Checks if an index exists in both ACIR and Brillig witness vectors | ||
| fn index_presented( |
|
|
||
| /// Gets an element from an array at the given index | ||
| fn insert_array_get(&mut self, array_idx: u32, index: u32) { | ||
| if array_idx >= self.acir_arrays.len() as u32 |
There was a problem hiding this comment.
It is better to just use indices modulo lengths. Otherwise the majority of testcases will skip instructions instead of creating them
| /// Sets an element in an array at the given index | ||
| fn insert_array_set(&mut self, array_idx: u32, index: u32, value: u32) { | ||
| if array_idx >= self.acir_arrays.len() as u32 | ||
| || array_idx >= self.brillig_arrays.len() as u32 |
| } | ||
|
|
||
| /// Checks if an index exists in both ACIR and Brillig witness vectors | ||
| fn index_presented( |
There was a problem hiding this comment.
It seems like you are duplicating functionality from field.rs here
Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com>
Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com>
Co-authored-by: Innokentii Sennovskii <isennovskiy@gmail.com>
tooling/nargo/src/ops/mod.rs
Outdated
| @@ -11,7 +11,7 @@ pub use self::test::{TestStatus, run_test}; | |||
|
|
|||
| mod check; | |||
| mod compile; | |||
| mod execute; | |||
| pub mod execute; | |||
There was a problem hiding this comment.
| pub mod execute; | |
| mod execute; |
There was a problem hiding this comment.
I need it here
There was a problem hiding this comment.
We reexport that function a couple of lines up.
Description
Summary*
This PR introduces SSA fuzzer for testing ACIR and Brillig execution of ssa built from scratch.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.