Make dev and prod routes consistent #142
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR to keep routes consistent between dev and prod environments.
The change rests on two main things
/api
. I think this makes more sense anyway, when someone readsnomad-rest-api/app.js
it is immediately clear what the correct routes are. As it currently stands the reader also has to have knowledge about how the app is deployed with nginx to know that the routes would need to be prefixed with/api/
if they wish to send requests to the backend./api/
from routes forwarded to the server. Because the backend explicitly serves routes prefixed with/api/
this bit of config is no longer necessary.Small optional changes:
version
indocker-compose.yaml
- my docker compose keeps complaining that this key is not longer supported