-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregated pull requests (with pull request 62) #63
Conversation
Replaced 'text-transform' with correct attribute 'text-anchor' to set rotation center of labels.
Adding d3.event to event listeners to maintain consistency between models. In the historical bar chart they are included, but not the line which uses the scatters events.
Added donutRatio public variable to pie model. Allows customization of the inner radius of the donut pie chart.
This allows an axis to change orientation and have the tick label respond accordingly.
the variable brushExtent is documented as a public variable but is not currently exposed. this exposes it allowing the user to control which portion of the crossfilter is selected at initiation.
Cannot read property 'values' of undefined nv.d3.js:8498 Cannot read property 'values' of undefined nv.d3.js:8511
Problem parsing d="MZ" error
Conflicts: nv.d3.js nv.d3.min.js
Conflicts: nv.d3.js nv.d3.min.js
…scatter-chart' into aggregated-pull-requests
…ed-pull-requests Conflicts: src/models/pie.js
Thank you so much, sorry I've been behind. How are things looking, I'll have to dig into the code a little, but if I hear things appear to be working as they should, I'll dig a little less deeper, and just do an overview of all the pull requests. |
I did a throughout test on everything. This pull request includes the bug fixes I did on the other pull request. I did it separated also to make it easier for you to review the bug fixes. There were three outstanding issues on the master branch of this repository. |
OK, sorry, snowstorm whiped out my weekend. I'll try to get this in in the next day or two so I can get this repo back up to date. |
No problem, I'm working on an issue that I have involving line charts, date/time X scales and redrawing data. Soon I'll have something to share about it. |
trying to do my sample I encountered a bug that is not present on this repository master. If possible, help me find it. It is reported on Bug report #67 |
Too many PR's in this, so closing. |
It aggregates: