DNM: Fix Fail-Safe after reboot #559
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adigie
force-pushed
the
fail-safe
branch
2 times, most recently
from
595ef2b to
ee2397a
Compare
adigie
force-pushed
the
fail-safe
branch
4 times, most recently
from
7ec58e6 to
f00901a
Compare
* Rename FailSafeCommitMarkerKey to FabricTableCommitMarkerKey Commit marker was moved from FailSafeContext to FabricTable in #20010, however name of the key wasn't changed and it's misleading. This commit changes the name of the method returning commit marker key, but keeps the key name for backward compatibility. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Remove declaration of non-existent method CommitToStorage was removed in #20010. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> (cherry picked from commit 4c7bbe0e1182acfeddfc2194ca2250c23f74bbda)
…ing CommitPendingFabricData (#37819) * Always clean up all data in FabricTable::Delete Always try to cleanup all fabric data regardless if fabric was initialized, as there may be some partial data stored if a device was reset during committing changes to storage. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Test FabricTable Delete Test if Delete invokes delegates, as this is needed to cleanup all fabric related settings after device is reset during committing changes to storage. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Fix test Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> * Fix return value Make Delete return the same errors as before the changes. Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> --------- Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no> (cherry picked from commit e95b91368ad52de36eda2e25282a00a7d74620dc)
FailSafeContext needs storage for marker. Upstream PR #: 37807 Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Upstream PR #: 37807 Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Upstream PR #: 37807 Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Upstream PR #: 37807 Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Test if: * Marker is stored during AddNOC. * Marker is not stored during UpdateNOC. * Marker is cleared During DisarmFailSafe and after timer expiry. Upstream PR #: 37807 Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: replace with commit fromtree