Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement RPC session iterator extensions #3818

Open
AnnaShaleva opened this issue Feb 24, 2025 · 1 comment · May be fixed by #3827
Open

Implement RPC session iterator extensions #3818

AnnaShaleva opened this issue Feb 24, 2025 · 1 comment · May be fixed by #3827
Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S3 Minimally significant U3 Regular
Milestone

Comments

@AnnaShaleva
Copy link
Member

Implement neo-project/neo#3429. Keep in mind that:

  • It should be an RPC server extension, move it under some SessionExpansionExtension and ensure that compatibility is preserved with C# nodes and old NeoGo servers.
  • Extend getversion response with this setting.
  • Ensure RPC client and unwrap package can work with both SessionExpansionExtension enabled and disabled.
  • Make sure Invoker can handle it properly.
@AnnaShaleva AnnaShaleva added enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S3 Minimally significant U3 Regular labels Feb 24, 2025
@AnnaShaleva AnnaShaleva added this to the v0.109.0 milestone Feb 24, 2025
@roman-khimov
Copy link
Member

Most likely we'll need to release a version, upgrade all clients and only then enable it in production, because obviously current clients can be confused upon receiving expanded iterator with session data.

AliceInHunterland added a commit that referenced this issue Mar 5, 2025
Close #3818

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland linked a pull request Mar 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving existing functionality I2 Regular impact rpc RPC server and client S3 Minimally significant U3 Regular
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants