core: split notarypool and mempool metrics #2969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2969 +/- ##
==========================================
+ Coverage 84.78% 84.86% +0.07%
==========================================
Files 329 328 -1
Lines 43034 43039 +5
==========================================
+ Hits 36485 36523 +38
+ Misses 5066 5031 -35
- Partials 1483 1485 +2
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
Move them to the core/network packages, close #2950. The name of mempool's unsorted transactions metrics has been changed along the way to match the core's metrics naming convention. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
commented
Apr 13, 2023
roman-khimov
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, do not use metrics for temporary pools created during block/transaction verification.
Close #2950.