vm: make slots public

[ixje]

as per #3674 (comment)

[ixje]

this will fail signed off because it doesn't like my format, looking at how to fix the commit :|

[AnnaShaleva]

It would be nice to add a link to the reason of this modification to the commit message (#3674 (comment)).

LGTM, but not merging without @roman-khimov's approval.

[AnnaShaleva]

looking at how to fix the commit :|

Expected "Erik van den Brink <git@erikvandenbrink.com>", but got "ixje <erik@coz.io>"

If you don't like the suggestion, then we can merge with this job failing, it's not critical.

[codecov]

Codecov Report

Attention: Patch coverage is 90.90909% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.02%. Comparing base (dda2caf) to head (7ec0c11).
Report is 14 commits behind head on master.

Files with missing lines	Patch %	Lines
cli/vm/cli.go	90.00%	1 Missing ⚠️
pkg/vm/context.go	85.71%	1 Missing ⚠️
pkg/vm/vm.go	88.88%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3677      +/-   ##
==========================================
- Coverage   83.09%   83.02%   -0.08%     
==========================================
  Files         334      334              
  Lines       46573    46612      +39     
==========================================
- Hits        38699    38698       -1     
- Misses       6306     6338      +32     
- Partials     1568     1576       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[roman-khimov]

looking at how to fix the commit

Whoever is in the "Author" of commit (git log, git config --get user.email) should be in SOB (at least the email should be the same).

[roman-khimov]

I'd suggest deprecating DumpXSlot at the same time, it was always questionable.

[ixje]

I'd suggest deprecating DumpXSlot at the same time, it was always questionable.

Those are in use by the cli

neo-go/cli/vm/cli.go

Lines 650 to 655 in cb51eeb

	case "sslot":
	rawSlot = vmCtx.DumpStaticSlot()
	case "lslot":
	rawSlot = vmCtx.DumpLocalSlot()
	case "aslot":
	rawSlot = vmCtx.DumpArgumentsSlot()

You want to remove these CLI commands?

[roman-khimov]

You want to remove these CLI commands?

Of course not, they can grab slots from VM as is and represent them to user in any way they want including JSON.

[AnnaShaleva]

Last comments, otherwise LGTM.