*: update neofs-sdk-go
#3725
*: update neofs-sdk-go
#3725
Conversation
AliceInHunterland
requested review from
AnnaShaleva and
roman-khimov
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3725 +/- ##
==========================================
+ Coverage 83.04% 83.11% +0.06%
==========================================
Files 335 335
Lines 46755 46752 -3
==========================================
+ Hits 38829 38859 +30
+ Misses 6333 6297 -36
- Partials 1593 1596 +3 ☔ View full report in Codecov by Sentry. |
AliceInHunterland
force-pushed
the
neofs-sdk-update
branch
from
acebfb9 to
264dee4
Compare
AliceInHunterland
force-pushed
the
neofs-sdk-update
branch
from
264dee4 to
3387980
Compare
|
@AliceInHunterland, resolve conflicts, convert from draft, rebase onto fresh master. |
AliceInHunterland
force-pushed
the
neofs-sdk-update
branch
from
3387980 to
cd6e864
Compare
Update to the version without pool panics nspcc-dev/neofs-sdk-go#643. Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
AliceInHunterland
force-pushed
the
neofs-sdk-update
branch
from
cd6e864 to
9e3f75e
Compare
Yes, I have checked both but with small values (IndexFileSize: 1000). |
There was a problem hiding this comment.
decode constructors are available now, u may find them useful https://github.com/nspcc-dev/neofs-sdk-go/blob/0b9bb748ea16370c9b88090a902413324e86bcf1/container/id/id.go#L40
| @@ -140,7 +138,7 @@ func retry(action func() error, maxRetries uint, debug bool) error { | |||
| } | |||
|
|
|||
| // uploadBlocksAndIndexFiles uploads the blocks and index files to the container using the pool. | |||
| func uploadBlocksAndIndexFiles(ctx *cli.Context, p poolWrapper, rpc *rpcclient.Client, signer user.Signer, containerID cid.ID, acc *wallet.Account, attr, indexAttributeKey string, buf []byte, currentIndexFileID, indexFileSize, currentBlockHeight uint, numWorkers, maxRetries uint, debug bool) error { | |||
| func uploadBlocksAndIndexFiles(ctx *cli.Context, p poolWrapper, rpc *rpcclient.Client, signer user.Signer, containerID cid.ID, ownerID user.ID, attr, indexAttributeKey string, buf []byte, currentIndexFileID, indexFileSize, currentBlockHeight uint, numWorkers, maxRetries uint, debug bool) error { | |||
There was a problem hiding this comment.
signer carries ID so u may drop ownerID prm
There was a problem hiding this comment.
Retry 0: failed to close object writer: status: code = 1024 message = missing object owner
There was a problem hiding this comment.
if I removing hdr.SetOwner(ownerID)
There was a problem hiding this comment.
hdr.SetOwner(signer.UserID())
| @@ -455,7 +450,7 @@ func uploadObj(ctx context.Context, p poolWrapper, signer user.Signer, owner uti | |||
| } | |||
| res := writer.GetResult() | |||
| resOID = res.StoredObjectID() | |||
| if resOID.Equals(oid.ID{}) { | |||
| if resOID.IsZero() { | |||
There was a problem hiding this comment.
this is done by ObjectPutInit
| hdr object.Object | ||
| prmObjectPutInit client.PrmObjectPutInit | ||
| resOID = oid.ID{} | ||
| ) | ||
|
|
||
| ownerID.SetScriptHash(owner) | ||
| hdr.SetPayload(objData) |
There was a problem hiding this comment.
What exactly is a no-op here?
There was a problem hiding this comment.
payload is unprocessed for hdr, it's written below. Object type system jukes now, but it will be improved soon nspcc-dev/neofs-sdk-go#652
Update to the version without pool panics.