Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native: add Echidna changes #3761

Merged
merged 5 commits into from
Dec 24, 2024
Merged

native: add Echidna changes #3761

merged 5 commits into from
Dec 24, 2024

Conversation

AliceInHunterland
Copy link
Contributor

@AliceInHunterland AliceInHunterland commented Dec 16, 2024

Close #3549
Close #3550
Close #3702

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 94.23077% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.03%. Comparing base (6d20772) to head (663146a).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
pkg/core/native/designate.go 84.21% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3761      +/-   ##
==========================================
- Coverage   83.08%   83.03%   -0.05%     
==========================================
  Files         335      335              
  Lines       46745    46821      +76     
==========================================
+ Hits        38836    38877      +41     
- Misses       6320     6352      +32     
- Partials     1589     1592       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AliceInHunterland AliceInHunterland changed the title native: add Designation event extension after HFEchidna native: add Echidna changes Dec 16, 2024
@AnnaShaleva
Copy link
Member

@AliceInHunterland ready for review? Tests are still failing.

@AliceInHunterland AliceInHunterland force-pushed the designate branch 3 times, most recently from ed26066 to 98ca307 Compare December 23, 2024 07:51
@AnnaShaleva
Copy link
Member

@AliceInHunterland ready for review?

Copy link
Member

@AnnaShaleva AnnaShaleva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need neo-go dependency upgrade.

Close #3549

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Close #3550

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Close #3702

Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AliceInHunterland AliceInHunterland force-pushed the designate branch 2 times, most recently from f415b82 to 9ddfe90 Compare December 23, 2024 15:52
Signed-off-by: Ekaterina Pavlova <ekt@morphbits.io>
@AnnaShaleva AnnaShaleva merged commit dc747ce into master Dec 24, 2024
33 of 34 checks passed
@AnnaShaleva AnnaShaleva deleted the designate branch December 24, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support callflags-based native method forks Base64URL support Designation event extension
2 participants