MPT: extend Billet documentation #3832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roman-khimov
reviewed
Mar 6, 2025
Billet's mode must match the DB's MPT mode, otherwise Billet-level nodes decoding won't work properly startign from 86cb4ed. Ref. #3808 (comment) and 49945e9. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
extend-billet-doc
branch
from
8af3544 to
f598a41
Compare
Use this constant as a dummy contract storage item prefix for those situations when Billet is used as an MPT search wrapper. Otherwise it's confusing to see `0` passed as a storage prefix to the billet constructor and then panic inside the Billet's code if this prefix is `0`. Ref. #2201. Signed-off-by: Anna Shaleva <shaleva.ann@nspcc.ru>
AnnaShaleva
force-pushed
the
extend-billet-doc
branch
from
f598a41 to
c3916ef
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3832 +/- ##
==========================================
- Coverage 82.90% 82.87% -0.04%
==========================================
Files 338 338
Lines 47435 47448 +13
==========================================
- Hits 39326 39322 -4
- Misses 6493 6506 +13
- Partials 1616 1620 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
roman-khimov
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes, but we need at least some basic doc in order not to confuse new developers.