Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make P2PNotaryRequestPayloadPoolSize configurable #3195

Merged

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Mar 3, 2025

Closes #3191.

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.16%. Comparing base (d74a7ad) to head (28cba9f).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/innerring/internal/blockchain/blockchain.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3195      +/-   ##
==========================================
+ Coverage   23.14%   23.16%   +0.02%     
==========================================
  Files         760      760              
  Lines       60499    60510      +11     
==========================================
+ Hits        14001    14020      +19     
+ Misses      45503    45499       -4     
+ Partials      995      991       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

End-rey added 2 commits March 3, 2025 18:31
Add `fschain.consensus.p2p_notary_request_payload_pool_size` option in config
to configure `P2PNotaryRequestPayloadPoolSize` parameter.

Closes #3191.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
Add tests for new options in ir config:
-`fschain.consensus.p2p_notary_request_payload_pool_size`
Refs #3126:
- `fschain.consensus.rpc.max_websocket_clients`
- `fschain.consensus.rpc.session_pool_size`
Refs #3093:
- `fschain.consensus.keep_only_latest_state`
- `fschain.consensus.remove_untraceable_blocks`

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@End-rey End-rey force-pushed the 3191-make-p2pnotaryrequestpayloadpoolsize-configurable branch from 07dc7e9 to 28cba9f Compare March 3, 2025 15:31
@roman-khimov roman-khimov merged commit a483e26 into master Mar 3, 2025
21 of 22 checks passed
@roman-khimov roman-khimov deleted the 3191-make-p2pnotaryrequestpayloadpoolsize-configurable branch March 3, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make P2PNotaryRequestPayloadPoolSize configurable
3 participants