Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add retries for Invoke function #3200

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Add retries for Invoke function #3200

merged 2 commits into from
Mar 4, 2025

Conversation

End-rey
Copy link
Contributor

@End-rey End-rey commented Mar 4, 2025

Closes #3198.

@End-rey
morph: retry only on temporary errors
daacd6b 
In #3190 added retries for sending notary requests that was received from Notary
service. Now retry only if there is `neorpc.ErrMempoolCapReached` error.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@End-rey End-rey self-assigned this Mar 4, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 4, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 41 lines in your changes missing coverage. Please review.

Project coverage is 23.15%. Comparing base (755f894) to head (e32e13d).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/morph/client/static.go 0.00% 35 Missing ⚠️
pkg/morph/client/notary.go 0.00% 6 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3200      +/-   ##
==========================================
- Coverage   23.15%   23.15%   -0.01%     
==========================================
  Files         760      760              
  Lines       60523    60550      +27     
==========================================
+ Hits        14017    14020       +3     
- Misses      45514    45539      +25     
+ Partials      992      991       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roman-khimov
roman-khimov reviewed Mar 4, 2025
View reviewed changes
@End-rey
morph: add retries for Invoke function
e32e13d 
All invokes from `StaticClient` are retry if there is
`neorpc.ErrMempoolCapReached` error.

Closes #3198.

Signed-off-by: Andrey Butusov <andrey@nspcc.io>
@End-rey End-rey force-pushed the 3198-sn-cant-send-heartbeat-in-a-big-network branch from fe4955b to e32e13d Compare March 4, 2025 16:20
@End-rey End-rey requested a review from roman-khimov March 4, 2025 16:24
@roman-khimov roman-khimov merged commit 951938a into master Mar 4, 2025
18 of 22 checks passed
@roman-khimov roman-khimov deleted the 3198-sn-cant-send-heartbeat-in-a-big-network branch March 4, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov approved these changes

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees

@End-rey End-rey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SN can't send heartbeat in a big network
2 participants
@End-rey @roman-khimov