Support Neo N3 account auth #3216
Draft
+68
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stateful auth scheme is about to come with #3194. With it, stateless `VerifySignature` will become unusable to process Container contract notifications. This inlines the verification method to make behavior more flexible. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Previously, IR Container contract's event processor logged 'invalid session token signature' for any case of the invalid session token signature, incl: 1. no signature at all; 2. unknown scheme; 3. wrong scheme; 4. mismatch. This behavior could make it more difficult to detect bugs. Now IR logs particular error for each mentioned case. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3216 +/- ##
=======================================
Coverage 23.42% 23.42%
=======================================
Files 760 760
Lines 60848 60847 -1
=======================================
+ Hits 14252 14255 +3
+ Misses 45588 45585 -3
+ Partials 1008 1007 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cthulhu-rider
force-pushed
the
feature/n3-auth
branch
from
e077364 to
31f8276
Compare
cthulhu-rider
force-pushed
the
feature/n3-auth
branch
2 times, most recently
from
4fc8fbc to
1406002
Compare
Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
force-pushed
the
feature/n3-auth
branch
from
1406002 to
790d352
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.