Fix sometimes failing integration tests #226
Merged
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integration tests added within 3747724 could fail on comparison of object's creation timestamp with `Date` HTTP response header. The tests asserted that they are equal which isn't true in general: according to https://datatracker.ietf.org/doc/html/rfc2616#section-14.18, `Date` header carries time when the response - not the object - was originated. At the same time, test results were inconsistent since values could equal if everything went pretty fast. Now tests assert that the response is created not earlier than the object. Signed-off-by: Leonard Lyubich <leonard@morphbits.io>
cthulhu-rider
requested review from
roman-khimov,
smallhive and
tatiana-nspcc
as code owners
cthulhu-rider
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #226 +/- ##
=======================================
Coverage 22.11% 22.11%
=======================================
Files 17 17
Lines 3305 3305
=======================================
Hits 731 731
Misses 2439 2439
Partials 135 135 ☔ View full report in Codecov by Sentry. |
roman-khimov
approved these changes
Jun 25, 2024
|
Nice improvement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
detected in unrelated PR
btw do we even care about
Dateresponse header? Gateway handler do not set it explicitly