-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sign multipart objects in the gate #1001
Sign multipart objects in the gate #1001
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1001 +/- ##
==========================================
+ Coverage 26.63% 26.67% +0.03%
==========================================
Files 88 88
Lines 14400 14564 +164
==========================================
+ Hits 3836 3885 +49
- Misses 10135 10244 +109
- Partials 429 435 +6 ☔ View full report in Codecov by Sentry. |
502ef75
to
e6d8cd8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dont we need some tests for it? Test code can be unified with SDK/node. Otherwise, it is impossible to keep everything in sync to me. Multiple codes do the same thing.
I checked the code with s3 gate tests locally and GH pipeline did it as well |
e6d8cd8
to
e59d186
Compare
@smallhive, i guess without #974 it also worked well but contained errors, right? I do not mean this must be done in this PR (at least something should appear in SDK) but I think we can discuss it at least. @roman-khimov |
e59d186
to
0acc780
Compare
It's make sence |
Closes #975. Signed-off-by: Evgenii Baidakov <evgenii@nspcc.io>
0acc780
to
4cff0fc
Compare
Closes #975.