Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add test for rest gw metrics #977

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

tests: add test for rest gw metrics #977

wants to merge 1 commit into from
+127 −48

Conversation

evgeniiz321
Copy link
Contributor

closes #938

@evgeniiz321 evgeniiz321 force-pushed the ezayats/rest-gw branch 2 times, most recently from 593b93e to b85fb82 Compare March 12, 2025 22:19
roman-khimov
roman-khimov reviewed Mar 14, 2025
View reviewed changes
pytest_tests/lib/helpers/rest_gate.py Outdated
@@ -183,7 +183,7 @@ def upload_via_rest_gate(
assert match, f"Expected {resp.text} to match {error_pattern}"
return ""
raise Exception(
f"""Failed to get object via REST gate:
f"""Failed to put object via REST gate:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate fix.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed

pytest_tests/tests/metrics/test_sn_metrics.py Outdated
@@ -331,3 +341,69 @@ def test_s3_gw_metrics(neofs_env_single_sn: NeoFSEnv, s3_boto_client):
# assert after_metrics_s3_gw["neofs_s3_version"][0]["params"]["version"] == neofs_s3_version, (
# "invalid value for neofs_s3_version"
# )


@pytest.mark.skip(reason="https://github.com/nspcc-dev/neofs-rest-gw/issues/274")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can omit some specific metric instead of a whole test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

tests: add test for rest gw metrics
24961f2 
closes #938

Signed-off-by: Evgeniy Zayats <zayatsevgeniy@nspcc.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roman-khimov roman-khimov roman-khimov left review comments

@carpawell carpawell Awaiting requested review from carpawell carpawell is a code owner

@cthulhu-rider cthulhu-rider Awaiting requested review from cthulhu-rider cthulhu-rider is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tests for REST GW metrics
2 participants
@evgeniiz321 @roman-khimov