Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting the format has no effect #14

Closed
ZechCodes opened this issue Jul 25, 2021 · 2 comments
Closed

Setting the format has no effect #14

ZechCodes opened this issue Jul 25, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@ZechCodes
Copy link

ZechCodes commented Jul 25, 2021 •
edited
Loading

Setting the temperature format to imperial has no effect, temperatures are still returned in metric.

The issue is that the session arg is being passed from python_weather.client.Client.__init__ as the first arg to python_weather.rest.HTTPClient. The HTTPClient expects the session to be the last arg.

https://github.com/vierofernando/python-weather/blob/e7908a2e47def82bfbb092ac73e159e43d99fb01/python_weather/rest.py#L12

https://github.com/vierofernando/python-weather/blob/e7908a2e47def82bfbb092ac73e159e43d99fb01/python_weather/client.py#L13
@null8626
Copy link
Owner

thanks for the bug report! will fix this in a future update really soon.

@null8626 null8626 added the bug Something isn't working label Jul 26, 2021
null8626 added a commit that referenced this issue Jul 26, 2021
@null8626
fix issue #14
85a8545
@null8626
Copy link
Owner

fixed on version 0.3.6, please let me know if other bug occurs, thanks!

null8626 added a commit that referenced this issue Oct 28, 2024
@null8626
fix issue #14
62aa404
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ZechCodes @null8626