added testInterpolation for 1d grids #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kunyuan
reviewed
May 27, 2021
src/grid/interpolate.jl
Outdated
| function testInterpolation1D(func, grid1, grid2) | ||
| data1 = [] | ||
| for i in 1:grid1.size | ||
| push!(data1, func(grid1[i])) |
There was a problem hiding this comment.
You may do it with the pythonic way
data1=[func(grid1[i]) for i in range(grid1.size)]
kunyuan
reviewed
May 27, 2021
src/grid/interpolate.jl
Outdated
| for i in 1:grid2.size | ||
| push!(data2, func(grid2[i])) | ||
| push!(data2_int, linear1D(data1, grid1, grid2[i])) | ||
| end |
kunyuan
reviewed
May 27, 2021
src/grid/interpolate.jl
Outdated
| data1 = [] | ||
| for i in 1:grid1.size | ||
| push!(data1, func(grid1[i])) | ||
| end |
kunyuan
reviewed
May 27, 2021
| for i in 1:grid2.size | ||
| push!(data2, func(grid2[i])) | ||
| push!(data2_int, linear1D(data1, grid1, grid2[i])) | ||
| end |
kunyuan
reviewed
May 29, 2021
|
|
||
| Test interpolation on grid1 with function func, compare results with func(grid2). | ||
| Return max deviation and std of deviation. | ||
|
|
There was a problem hiding this comment.
use the standard format for the comments:
#Arguments
func: function needs to be interpolatedgrid1: grid to testgrid2: grid to test
kunyuan
reviewed
May 29, 2021
src/grid/interpolate.jl
Outdated
| Return max deviation and std of deviation. | ||
|
|
||
| """ | ||
| function testInterpolation1D(func, grid1, grid2) |
There was a problem hiding this comment.
You may merge testInterpolation1D and testInterpolation1D_rel: You may add a flag relativeError`. If true, return relative error; if false, return absoluate error.
kunyuan
reviewed
May 29, 2021
| return d_max, d_std | ||
| end | ||
|
|
||
| function optimizeUniLog(generator, para, MN, func) |
There was a problem hiding this comment.
Use the standard format for the documentation
"""
function optimizeUniLog(generator, para, MN, func)
return an automatically optimized UniLog grid....
Arguments:
generator: functiongenerator(para, M, N)to generate a UniLog grid- ...
"""
kunyuan
approved these changes
May 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.