Explicitly build Legion if legion_dir
or legion_src_dir
is not provided
#411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where building and installing
legate.core
succeeds, but re-building and installinglegate.core
again (without uninstalling it first) seemingly succeeds but removes the Legion libs.Here's the output from two runs:
legate.core
wheel.As part of installing the wheel produced by step 2, pip first removes the files added by the previous installation (step 1), but it doesn't re-install Legion (because Legion was found in an install location and not built as a side-effect of building
legate.core
.)This PR forces
install.py
to tell CMake to always build Legion as part of buildinglegate.core
unless the user explicitly passes--with-legion
or--legion-src-dir
.