legate/util: fix a mypy error on MacOS #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes nv-legate#435. Signed-off-by: Rohan Yadav <rohany@alumni.cmu.edu>
rohany
added
the
category:bug-fix
bryevdv
approved these changes
Oct 14, 2022
manopapad
pushed a commit
that referenced
this pull request
Mar 5, 2025
* Switch to a new scoping mechanism * Make ScopeImpl an inner class * Extend Scope to hold more than one override request * Docstrings for the new Scope class * Disallow nested scopes using the same machine in Python * Some unit tests for Scope * Pipe through the priority value to the mapper * Make get_machine return a reference and fix clang-tidy issues * Update the Python API for Scope * Remove dead code * Address review comments * Put back const auto& that somehow got lost during merge * More fixes for clang-tidy * Address review comments * Missing comment * More review comment to address * Another review comment to address * Make sure scope_ is reset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435.
Signed-off-by: Rohan Yadav rohany@alumni.cmu.edu