Construct region-backed 0D stores in a correct way #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magnatelee
added
the
category:bug-fix
This was referenced Oct 21, 2022
manopapad
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The core runtime currently accepts 0D shapes (
()) for region-backed stores, which can later cause all sorts of inconsistencies, because 0D regions don't exist. This PR fixes that issue by constructing 0D stores as 1D singleton stores projected on the first dimension. This is sufficient to fix nv-legate/cupynumeric#500 since the transformation code already handles the exceptional 0D cases correctly.